Bug 98 – Icon for the JavaFX perspective

Bug 98 - Icon for the JavaFX perspective

Summary:

Icon for the JavaFX perspective

Status:	RESOLVED FIXED

Product:	eplugin
Component:	source
Version:	1
Platform:	PC Windows

Importance:	P5 enhancement
Assigned To:	dkaspar@kenai.com

URL:
Whiteboard:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-12-14 19:49 by vogella@kenai.com
Modified:	2009-01-07 08:33 (History)

Attachments
Perspective without icon (5.03 KB, image/gif) 2008-12-14 19:50, vogella@kenai.com	Details
Perspective without icon (5.03 KB, image/gif) 2008-12-14 20:15, vogella@kenai.com	Details
Screen shot of the JavaFX perspective icon (4.52 KB, image/png) 2008-12-24 17:22, sinnema313@kenai.com	Details
Patch to add icons to the jar files built (775 bytes, patch) 2008-12-26 21:25, sinnema313@kenai.com	Details \| Diff
Hide Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From vogella@kenai.com 2008-12-14 19:49:44

Hi,

this one should be a quick fix: Can you please add an icon for the JavaFX
perspective?

Best regards, Lars

------- Comment #1 From vogella@kenai.com 2008-12-14 19:50:51 -------

Created an attachment (id=13) [details]
Perspective without icon

Perspective without icon

------- Comment #2 From vogella@kenai.com 2008-12-14 20:15:20 -------

Created an attachment (id=14) [details]
Perspective without icon

Perspective without icon

------- Comment #3 From sinnema313@kenai.com 2008-12-24 17:22:34 -------

Created an attachment (id=21) [details]
Screen shot of the JavaFX perspective icon

Works for me (trunk)

------- Comment #4 From vogella@kenai.com 2008-12-25 23:06:27 -------

It looks like you are not including the directory icons in your build. I
checked and see that your perspective defined in com.sun.javafx.eclipse.core
uses the directory.

<extension
        point="org.eclipse.ui.perspectives">
     <perspective
           class="com.sun.javafx.eclipse.core.FXPerspectiveFactory"
           icon="icons/javafx_icon.png"
           id="com.sun.javafx.eclipse.core.perspective"
           name="JavaFX">
     </perspective>
  </extension>

If you extract your exported plug-in
(com.sun.javafx.eclipse.feature-win32-win32-x86-1.0.zip from your website) you
will see that the icon directory is missing.

Best regards, Lars

------- Comment #5 From sinnema313@kenai.com 2008-12-26 21:25:45 -------

Created an attachment (id=24) [details]
Patch to add icons to the jar files built

------- Comment #6 From dkaspar@kenai.com 2009-01-06 10:32:31 -------

Thanks for the patch. Fixed as proposed.

------- Comment #7 From vogella@kenai.com 2009-01-06 21:13:39 -------

Thank you. Can you please update the download
(http://kenai.com/projects/eplugin/downloads)?

------- Comment #8 From Martin Ryzl 2009-01-07 08:33:23 -------

Re updated builds - please be patient, we'll update the builds as soon as the
current wave of bugfixing is done.