Issue Details (XML | Word | Printable)

Key: BETTERBEANSBINDING-58
Type: Improvement Improvement
Status: Open Open
Priority: Major Major
Assignee: fabriziogiudici
Reporter: subes
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
BetterBeansBinding

Give more information if addPropertyChangeListener() fails

Created: 07/Nov/11 05:43 PM   Updated: 07/Nov/11 05:43 PM
Component/s: None
Affects Version/s: None
Fix Version/s: None

Time Tracking:
Not Specified

Tags:


 Description  « Hide

Currently the output is as follows:
Nov 07, 2011 6:34:17 PM org.jdesktop.beansbinding.util.logging.Logger log
Warnung: addPropertyChangeListener(): can't add listener

It would be much better if the message told on which class it failed, so the implementation can be fixed more easily. The desired message looks like this:
Nov 07, 2011 6:34:17 PM org.jdesktop.beansbinding.util.logging.Logger log
Warnung: addPropertyChangeListener(): can't add listener on class [some.package.SomeClass].

Or maybe some more user friendly:
Nov 07, 2011 6:34:17 PM org.jdesktop.beansbinding.util.logging.Logger log
Warnung: addPropertyChangeListener(): can't add listener on class [some.package.SomeClass]. Please add the method signature [addPropertyChangeListener(java.beans.PropertyChangeListener)] to fix this.

This is the fixed method in ELProperty.java:
----------------------------------------------
/**

  • @throws PropertyResolutionException
    */
    private static void addPropertyChangeListener(Object object,
    PropertyChangeListener listener) {
    EventSetDescriptor ed = getEventSetDescriptor(object);
    Method addPCMethod = null;

if ((ed == null) || ((addPCMethod = ed.getAddListenerMethod()) == null)) { logger.warning("addPropertyChangeListener(): can't add listener on class "+object.getClass().getName()); return; }

invokeMethod(addPCMethod, object, listener);
}
----------------------------------------------



There are no comments yet on this issue.