
| Key: |
JRUBY_RACK-14
|
| Type: |
Bug
|
| Status: |
Resolved
|
| Resolution: |
Fixed
|
| Priority: |
Minor
|
| Assignee: |
Unassigned
|
| Reporter: |
michaelpitman
|
| Votes: |
0
|
| Watchers: |
0
|
|
If you were logged in you would be able to see more operations.
|
|
|
Spec ruby/rack/servlet_spec.rb fails on my machine because HttpServlet.service(javax.servlet.http.HttpServletRequest _, javax.servlet.http.HttpServletResponse _) is not overridden by RackServlet, as called from the spec.
The following patch allows it to build. The system behavior does not seem to be affected by this change at all.
— a/src/main/java/org/jruby/rack/RackServlet.java
+++ b/src/main/java/org/jruby/rack/RackServlet.java
@@ -41,9 +41,14 @@ public class RackServlet extends HttpServlet {
}
@Override
- public void service(ServletRequest request, ServletResponse response)
+ public void service(HttpServletRequest request, HttpServletResponse
response)
throws ServletException, IOException {
- dispatcher.process((HttpServletRequest) request,
(HttpServletResponse) response);
+ dispatcher.process(request, response);
}
+ @Override
+ public void service(ServletRequest request, ServletResponse response)
+ throws ServletException, IOException {
+ service((HttpServletRequest) request, (HttpServletResponse)
response);
+ }
}
|
|
Description
|
Spec ruby/rack/servlet_spec.rb fails on my machine because HttpServlet.service(javax.servlet.http.HttpServletRequest _, javax.servlet.http.HttpServletResponse _) is not overridden by RackServlet, as called from the spec.
The following patch allows it to build. The system behavior does not seem to be affected by this change at all.
— a/src/main/java/org/jruby/rack/RackServlet.java
+++ b/src/main/java/org/jruby/rack/RackServlet.java
@@ -41,9 +41,14 @@ public class RackServlet extends HttpServlet {
}
@Override
- public void service(ServletRequest request, ServletResponse response)
+ public void service(HttpServletRequest request, HttpServletResponse
response)
throws ServletException, IOException {
- dispatcher.process((HttpServletRequest) request,
(HttpServletResponse) response);
+ dispatcher.process(request, response);
}
+ @Override
+ public void service(ServletRequest request, ServletResponse response)
+ throws ServletException, IOException {
+ service((HttpServletRequest) request, (HttpServletResponse)
response);
+ }
} |
Show » |
Sort Order:
|
In 7ed348f.