Issue Details (XML | Word | Printable)

Key: JRUBY_RACK-14
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Unassigned
Reporter: michaelpitman
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
jruby-rack

RackServlet does not override both service method signatures of HttpServlet

Created: 30/Jun/09 03:16 AM   Updated: 20/Aug/09 10:18 PM   Resolved: 20/Aug/09 10:18 PM
Component/s: None
Affects Version/s: 0.9.4
Fix Version/s: 0.9.5

Time Tracking:
Not Specified

Environment:

JDK1.6 / Servlet 2.5


Tags:


 Description  « Hide

Spec ruby/rack/servlet_spec.rb fails on my machine because HttpServlet.service(javax.servlet.http.HttpServletRequest _, javax.servlet.http.HttpServletResponse _) is not overridden by RackServlet, as called from the spec.

The following patch allows it to build. The system behavior does not seem to be affected by this change at all.

— a/src/main/java/org/jruby/rack/RackServlet.java
+++ b/src/main/java/org/jruby/rack/RackServlet.java
@@ -41,9 +41,14 @@ public class RackServlet extends HttpServlet {
}

@Override

  • public void service(ServletRequest request, ServletResponse response)
    + public void service(HttpServletRequest request, HttpServletResponse
    response)
    throws ServletException, IOException { - dispatcher.process((HttpServletRequest) request, (HttpServletResponse) response); + dispatcher.process(request, response); }

+ @Override
+ public void service(ServletRequest request, ServletResponse response)
+ throws ServletException, IOException { + service((HttpServletRequest) request, (HttpServletResponse) response); + }
}



Nick Sieger added a comment - 20/Aug/09 10:18 PM

In 7ed348f.