PeteHelgren
|
Posted: June 11, 2009 20:24 by PeteHelgren
|
|
I posted a query about committing a new adapter to the project in an email to Nick a while back and the response was: "I encourage you to get the latest and try to integrate your patches." Two questions arise: 1. If I did have patches that were changes to activerecord-jdbc base code, *how* would I integrate them? I have found (with limited knowledge) that github is a bit of a mystery to use and, for us Windows folks git, itself, is a bit of a challenge. Is there a decent, beginner level tutorial on using git with github for a Windows user? 2. In this case, I have a complete, new adapter file to commit with a small tweak to jdbc_adapter_spec.rb. How would I "integrate" these changes? Thanks, Pete |
Contributing an adapter
3 posts
Replies: 2 - Last Post: June 13, 2009 01:07
by: PeteHelgren
by: PeteHelgren
showing 1 - 3 of 3
Nick Sieger
|
Posted: June 12, 2009 02:14 by Nick Sieger
|
|
If you aren't able to get the code with git, you can download a tarball of the latest source, but in order to submit a patch you'll need to keep a copy of the original, make your changes, and create a patch of the changes. I'd really recommend trying something like TortoiseGit (http://code.google.com/p/tortoisegit/) as a way to work with the source; it will make the process of creating a patch much easier. In the case of a new adapter file, we can take it as is, but we'd also like to understand how to run it, maintain it, etc. Can we rely on you to keep the code up to date as the overall codebase changes? Another option would be for us to find a way to modularize the code so that your code doesn't need to be distributed with the main adapter in order to function. /Nick |
|
PeteHelgren
|
Posted: June 13, 2009 01:07 by PeteHelgren
|
|
I'll have to investigate it further then. I think I have git bash but I have only used it to pull code. I have never tried to push any changes. It looks like there might be a git plugin for Eclipse so I might check that out. I have a complete adapter for DB2 on IBM i that I would like to contribute and I would be happy to maintain it. The syntax on DB2 on IBM i is different than DB2 on LUW so I decided to create a separate adapter rather than try to keep integrating changes. There is a separate JDBC adapter for DB on IBM i as well so this would be consistent. I need to run the tests against it one more time but it should be ready to go. I can provide a link to the file and then just the adapter spec would need to be updated. |
Replies: 2 - Last Post: June 13, 2009 01:07
by: PeteHelgren
by: PeteHelgren
