[igv~mercurial:37] * Don't internalize strings from parsed graphs, it's expensive and can le

[peter.hofer@kenai.com]

Project:    igv
Repository: mercurial
Revision:   37
Author:     peter.hofer
Date:       2012-01-25 18:15:30 UTC
Link:       

Log Message:
------------
* Don't internalize strings from parsed graphs, it's expensive and can lead 
to OutOfMemoryErrors in the perm gen space for huge graphs
* Update call graph filter


Revisions:
----------
37


Modified Paths:
---------------
IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/Parser.java
IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/XMLParser.java
IdealGraphVisualizer/Graal/src/com/sun/hotspot/igv/graal/filters/callgraph.filter


Diffs:
------
diff -r 2d4ad853aa8f -r 6b33ceb3281f 
IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/Parser.java
--- 
a/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/Parser.java
  Mon Jan 09 16:08:01 2012 +0100
+++ 
b/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/Parser.java
  Wed Jan 25 19:15:30 2012 +0100
@@ -293,7 +293,7 @@
         @Override
         protected InputBlock start() throws SAXException {
             InputGraph graph = getParentObject();
-            String name = 
readRequiredAttribute(BLOCK_NAME_PROPERTY).intern();
+            String name = readRequiredAttribute(BLOCK_NAME_PROPERTY);
             InputBlock b = graph.addBlock(name);
             for (InputNode n : b.getNodes()) {
                 assert graph.getBlock(n).equals(b);
@@ -447,12 +447,12 @@
 
         @Override
         public String start() throws SAXException {
-            return readRequiredAttribute(PROPERTY_NAME_PROPERTY).intern();
+            return readRequiredAttribute(PROPERTY_NAME_PROPERTY);
          }
 
         @Override
         public void end(String text) {
-            getParentObject().getProperties().setProperty(getObject(), 
text.trim().intern());
+            getParentObject().getProperties().setProperty(getObject(), 
text.trim());
         }
     };
 

diff -r 2d4ad853aa8f -r 6b33ceb3281f 
IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/XMLParser.java
--- 
a/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/XMLParser.java
       Mon Jan 09 16:08:01 2012 +0100
+++ 
b/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/XMLParser.java
       Wed Jan 25 19:15:30 2012 +0100
@@ -150,8 +150,8 @@
         public void processAttributesAsProperties(Properties p) {
             int length = attr.getLength();
             for (int i = 0; i < length; i++) {
-                String val = attr.getValue(i).intern();
-                String localName = attr.getLocalName(i).intern();
+                String val = attr.getValue(i);
+                String localName = attr.getLocalName(i);
                 p.setProperty(val, localName);
             }
         }

diff -r 2d4ad853aa8f -r 6b33ceb3281f 
IdealGraphVisualizer/Graal/src/com/sun/hotspot/igv/graal/filters/callgraph.filter
--- 
a/IdealGraphVisualizer/Graal/src/com/sun/hotspot/igv/graal/filters/callgraph.filter
 Mon Jan 09 16:08:01 2012 +0100
+++ 
b/IdealGraphVisualizer/Graal/src/com/sun/hotspot/igv/graal/filters/callgraph.filter
 Wed Jan 25 19:15:30 2012 +0100
@@ -1,5 +1,4 @@
-colorize("abstract", "1", yellow);
+colorize("name", "<init>.*", yellow);
+colorize("name", "<clinit>.*", pink);
 colorize("leaf", "1", lightGray);
-
-var f = new com.sun.hotspot.igv.filter.EdgeColorIndexFilter("INPUTS", 
[black, pink]);
-f.apply(graph);
+colorize("cutoff", "1", red);