sumit.jaiswal
|
Posted: April 20, 2011 06:17 by sumit.jaiswal
|
|
Hi Mike, I am using the JBosh library for one of my current project. We are using jdk 1.6 and it worked perfectly. But once we shifted to jdk 1.5, we could see that we could no longer get new bosh connection because java 1.6 would automatically use SSLContext if it detects secure communication to the end point but this is not the case with java 1.5. So there needs to be a fix in XLightWebSender implementation. I have done the changes for the JBosh library to work with jdk 1.5. I would like to add this fix to main branch. Can you let me know how this can be done. And further would like to contribute to this project actively. regards, Sumit |
Contributing to JBosh Project
4 posts
Replies: 3 - Last Post: April 30, 2011 00:27
by: Mike Cumings
by: Mike Cumings
« Older Topic
» Newer Topic
showing 1 - 4 of 4
Mike Cumings
|
Posted: April 28, 2011 03:22 by Mike Cumings
|
|
Hi Sumit, Thanks for inquiring. If you supply a patch, I'll evaluate the changes and likely integrate them into the project. Some Java 6 features are used in favor of their older counterparts for their functional benefits however so I'd be more reluctant to integrate some changes. Please pass on a patch and we'll do what we can. At worst, I can create a branch/release for Java 5 compatibility. Mike |
|
sumit.jaiswal
|
Posted: April 28, 2011 13:18 by sumit.jaiswal
|
|
Hi Mike, Sorry for the delay. I have updated the patch in the below location. http://min.us/mvfM0mR Here is the patch contents: Index: XLightWebSender.java =================================================================== --- XLightWebSender.java (revision 36) +++ XLightWebSender.java (working copy) @@ -71,7 +71,12 @@ lock.lock(); try { cfg = session; - client = new HttpClient(); + if(session.getSSLContext()!=null){ + client = new HttpClient(session.getSSLContext()); + } + else{ + client = new HttpClient(); + } if (cfg != null && cfg.getProxyHost() != null && cfg.getProxyPort() != 0) { regards, Sumit |
|
Mike Cumings
|
Posted: April 30, 2011 00:27 by Mike Cumings
|
|
Just committed this to trunk and deployed a snapshot to the project's subversionized maven repo. I forget whether or not the snapshots will also be picked up by the central maven repo - it's been a while since I set it up. Do you need/want an official version spun up, or is this good enough for your usage? Thanks for the patch submission! |
Replies: 3 - Last Post: April 30, 2011 00:27
by: Mike Cumings
by: Mike Cumings
« Older Topic
» Newer Topic
