Suggestions: Support Java 5 and JavaScript comments in PAC scripts?

» Back to forum topics
  2 posts   Feedicon  
Replies: 1 - Last Post: September 16, 2009 17:46
by: HxA
« Older Topic » Newer Topic
showing 1 - 2 of 2
 
jlamoureaux
Defaultpersonimage
Posted: September 11, 2009 21:47 by jlamoureaux
» Permalink
Hello,

I've tried out your code and it's working pretty well for me. I had a requirement to develop and deploy on Java 5, though, and so had to make a few minor changes to the source to get it to compile with JDK 5.

Also, I had the interesting experience of finding an issue with PAC script parsing where - if the PAC script contained any single-line comments (i.e., // this is a comment), then the evaluation would yield 'undefined'. I fixed this locally by adding back the line endings that are removed when calling BufferedReader.readLine in UrlPacScriptSource.

All-in-all, I've enjoyed reading through the code, and appreciate your hard work!

Thanks. --jim

P.S.: let me know if you'd like any of the changes that I've made.
 
HxA
Defaultpersonimage
Posted: September 16, 2009 17:46 by HxA
» Permalink
Hello Jim,
Thanks for your feedback. I started the project some time ago but I still needs some work to mature. All feedback and patches are welcome. I will have a look at the issues that you have found.

Thanks,
- Bernd
Replies: 1 - Last Post: September 16, 2009 17:46
by: HxA
« Older Topic » Newer Topic
  • Mysql
  • Glassfish
  • Jruby
  • Rails
  • Nblogo
Terms of Use; Privacy Policy;
© 2010, Oracle Corporation and/or its affiliates
(revision 20120518.3c65429)
 
 
Close
loading
Please Confirm
Close